[PATCH v4 09/13] ARM: dts: sun8i: r40: add sata node

On Fri, Aug 31, 2018 at 3:56 PM Corentin Labbe
[off-list ref] wrote:

On Fri, Aug 31, 2018 at 09:35:00AM +0200, Maxime Ripard wrote:

quoted

On Thu, Aug 30, 2018 at 09:01:16PM +0200, Corentin Labbe wrote:

quoted

R40 have a sata controller which is the same as A20.
This patch adds a DT node for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 arch/arm/boot/dts/sun8i-r40.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 852c2ccc3268..d6b5820da850 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi

@@ -550,6 +550,29 @@
                    #size-cells = <0>;
            };

+           ahci: sata at 1c18000 {
+                   compatible = "allwinner,sun8i-r40-ahci";
+                   reg = <0x01c18000 0x1000>;
+                   interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
+                   clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>;
+                   resets = <&ccu RST_BUS_SATA>;
+                   resets-name = "ahci";
+                   #address-cells = <1>;
+                   #size-cells = <0>;
+                   status = "disabled";
+
+                   sata_port: sata-port at 0 {
+                           reg = <0>;
+                           phys = <&sata_phy>;
+                   };
+           };
+
+           sata_phy: sata-phy at 1c180c0  {
+                   compatible = "allwinner,sun8i-r40-sata-phy";
+                   reg = <0x1c180c0 0x200>;

Overlapping devices in the DTS is not ok.

I do the same than arch/arm/boot/dts/berlin2.dtsi (sata at e90000 phy at e900a0)
But since it is not a good justification, it seems that regmap is my only solution ?

Since you are effectively splitting one device node into two, you should
adjust the original (ahci) device nodes register range.

ChenYu