-----Original Message-----
From: Vinod <vkoul@kernel.org>
Sent: Tuesday, August 21, 2018 9:20 PM
To: Radhey Shyam Pandey <redacted>
Cc: dan.j.williams at intel.com; Michal Simek <redacted>; Appana
Durga Kedareswara Rao [off-list ref]; lars at metafoo.de;
dmaengine at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
kernel at vger.kernel.org
Subject: Re: [PATCH 2/3] dmaengine: xilinx_dma: Refactor axidma channel
validation

On 27-07-18, 16:20, Radhey Shyam Pandey wrote:

quoted

In axidma start_transfer, prefer checking channel states before other
params i.e pending_list.

and what that preference be?

There is no strict preference. I thought to group and first check channel
states(idle/error) and then look for pending list.

Thanks,
Radhey

quoted

Signed-off-by: Radhey Shyam Pandey <redacted>
---
 drivers/dma/xilinx/xilinx_dma.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/xilinx/xilinx_dma.c

b/drivers/dma/xilinx/xilinx_dma.c index 06d1632..a37871e 100644

--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c

@@ -1271,10 +1271,10 @@ static void xilinx_dma_start_transfer(struct

xilinx_dma_chan *chan)

quoted

 	if (chan->err)
 		return;

-	if (list_empty(&chan->pending_list))
+	if (!chan->idle)
 		return;

-	if (!chan->idle)
+	if (list_empty(&chan->pending_list))
 		return;

 	head_desc = list_first_entry(&chan->pending_list,
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe dmaengine"
in the body of a message to majordomo at vger.kernel.org More majordomo
info at  http://vger.kernel.org/majordomo-info.html

--
~Vinod