[PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property.
From: robh@kernel.org (Rob Herring)
Date: 2018-08-15 22:26:09
Also in:
linux-devicetree, linux-rockchip, lkml
On Wed, Aug 15, 2018 at 11:59:34AM +0200, Enric Balletbo i Serra wrote:
quoted hunk ↗ jump to hunk
This property is used when the otg-id pin is not connected. When this property is set it forces to set the B-Device Session Valid bit when the port works as device and clears that bit when the port works as host. Signed-off-by: Enric Balletbo i Serra <redacted> --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt index 2d4808d3920b..55761f466c41 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt@@ -48,6 +48,11 @@ Optional properties: See ./phy-bindings.txt for details. - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. Otherwise, use the bvalid register. + - rockchip,force-bvalid : boolean, set this to force the B-Device Session + Valid bit when the usb port is in device mode. This + is used when the otg-id pin is not connected. + Only supported in case of compatible being: + * "rockchip,rk3399-usb2phy"
Shouldn't you describe the property of the h/w that ID pin is not connected, rather than what you do with that information. Is the pin not connected because it's a connector without ID pin? If so, that should be a property of the connector (or inferred from the connector compatible string). Rob