[PATCH 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic
From: p.zabel@pengutronix.de (Philipp Zabel)
Date: 2018-07-24 07:49:11
Also in:
dri-devel, linux-samsung-soc
Hi Alexandru, On Fri, 2018-07-20 at 22:15 +0100, Alexandru Gheorghe wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Alexandru Gheorghe <redacted> --- drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 203f247d4854..1bd4de03ce9e 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c@@ -281,16 +281,14 @@ static void ipu_plane_state_reset(struct drm_plane *plane) ipu_state = to_ipu_plane_state(plane->state); __drm_atomic_helper_plane_destroy_state(plane->state); kfree(ipu_state); + plane->state = NULL;
With __drm_atomic_helper_plane_reset as-is, this could be dropped ...
}
ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL);
- if (ipu_state) {
- ipu_state->base.plane = plane;
- ipu_state->base.rotation = DRM_MODE_ROTATE_0;
- }
+ if (ipu_state)
+ __drm_atomic_helper_plane_reset(plane, &ipu_state->base);... if this is change to just __drm_atomic_helper_plane_reset(plane, &ipu_state->base);
- plane->state = &ipu_state->base; } static struct drm_plane_state *
regards Philipp