Thread (74 messages) 74 messages, 6 authors, 2018-08-09

[PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit

From: jassisinghbrar@gmail.com (Jassi Brar)
Date: 2018-07-26 10:15:59
Also in: linux-devicetree

On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel
[off-list ref] wrote:

.....
+
+/* Control Register */
+#define IMX_MU_xCR             0x24
+/* Transmit Interrupt Enable */
+#define IMX_MU_xCR_TIEn(x)     BIT(20 + (3 - (x)))
+/* Receive Interrupt Enable */
+#define IMX_MU_xCR_RIEn(x)     BIT(24 + (3 - (x)))
+
+#define IMX_MU_CHANS   4u
+
The 'u' unnecessarily refreshes my knowledge of C  :)

+struct imx_mu_con_priv {
+       int                     irq;
+       unsigned int            idx;
+       char                    *irq_desc;
Having      char  irq_desc[16];    seems simpler than free/kfree upon
each startup/shutdown. Simply use snprintf() in probe().

The rest of the driver seems fine.

Cheers!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help