[PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0
From: aisheng.dong@nxp.com (A.s. Dong)
Date: 2018-07-26 11:00:38
Also in:
linux-devicetree, lkml
-----Original Message----- From: Jassi Brar [mailto:jassisinghbrar at gmail.com] Sent: Thursday, July 26, 2018 5:42 PM To: Oleksij Rempel <o.rempel@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org>; Fabio Estevam [off-list ref]; Rob Herring [off-list ref]; Mark Rutland [off-list ref]; A.s. Dong [off-list ref]; Vladimir Zapolskiy [off-list ref]; Sudeep Holla [off-list ref]; Devicetree List [off-list ref]; Linux Kernel Mailing List [off-list ref]; , Sascha Hauer [off-list ref]; , linux-arm-kernel at lists.infradead.org, linux- mediatek at lists.infradead.org, srv_heupstream <linux-arm- kernel at lists.infradead.org>; dl-linux-imx [off-list ref] Subject: Re: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0 On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel [off-list ref] wrote:quoted
From: Dong Aisheng <aisheng.dong@nxp.com> Mailbox devices may have only one channel which means the mbox-cells at least 1 does not make sense for this type devices. Let's remove that limitation to allow the mbox-cells to be equal to 0.OK But please realise that you'll have to write more code -- implement your own of_xlate() callback. Most developers would prefer to call the only channel as channel number 0, and use the common of_xlate implementation.
Yes, that's true because the common of_xlate assuming the mbox-cells is 1. And there's already such users: arch/arm/boot/dts/bcm283x.dtsi More comments will be on your reply of patch-3. Regards Dong Aisheng
-jassi