Thread (16 messages) 16 messages, 6 authors, 2018-07-30

[PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC

From: Andy Shevchenko <hidden>
Date: 2018-07-30 08:39:10
Also in: linux-devicetree, linux-spi, lkml

On Mon, Jul 30, 2018 at 8:30 AM, Keiji Hayashibara
[off-list ref] wrote:
Hello Trent and Andy,
quoted
quoted
quoted
+       ckrat = roundup(ckrat, 2);
ckrat += ckrat & 1;
Either way, the compiler produces the same code:

 add r0, r0, #1
 bic r0, r0, #1

I.e., ckrat = (ckrat + 1) & ~1, one "add" and one "and".

Might as well use the macro so it's clear. There is also round_up(x,y), which I believe is intended to be used
only with power of 2 values of y.
I confirmed round_up() macro.
This macro is optimized to power of 2 argument,
and it matches to this case and clear.

I will replace to round_up() macro.
Good!


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help