On Thu, Jul 26, 2018 at 12:38 PM, Keiji Hayashibara
[off-list ref] wrote:

quoted

quoted

+       /* check if requested speed is too small */
+       if (ckrat > SSI_MAX_CLK_DIVIDER)

quoted

+               return -EINVAL;

So, does this critical?

If set the value to SSI_MAX_CLK_DIVIDER, the clock frequency will be set high.
I don't change it to high frequency, and it is daringly an error.
On the other hand, when changing to low frequency, I will change it automatically.

No. My point is, if somehow user asks for that condition to be
happened you bail out, while when using clamp_val() you may continue
to work at maximum limit, though issue warning to user, for example.

quoted

quoted

+
+       if (ckrat < SSI_MIN_CLK_DIVIDER)
+               ckrat = SSI_MIN_CLK_DIVIDER;

clamp_val()  / max() ?

I will modify it to use max().

See above.

-- 
With Best Regards,
Andy Shevchenko