[linux-sunxi] Re: [PATCH v3.1 10/10] arm64: dts: allwinner: a64: Enable HDMI output on A64 boards w/ HDMI
From: Jernej Škrabec <hidden>
Date: 2018-07-27 15:45:08
Also in:
dri-devel, linux-clk, linux-devicetree, lkml
Dne petek, 27. julij 2018 ob 17:42:08 CEST je Icenowy Zheng napisal(a):
? 2018-07-27 22:00?Maxime Ripard ???quoted
On Fri, Jul 27, 2018 at 09:26:11PM +0800, Icenowy Zheng wrote:quoted
? 2018?7?27? GMT+08:00 ??8:56:15, Maxime Ripard [off-list ref] ??:quoted
On Fri, Jul 27, 2018 at 01:12:57AM +0800, Icenowy Zheng wrote:quoted
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dtsquoted
index 1b9b92e541d2..1b972bade9f6 100644--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts@@ -62,6 +62,21 @@ chosen { stdout-path = "serial0:115200n8"; }; + + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; +}; + +&de { + status = "okay"; }; &ehci0 {@@ -82,6 +97,17 @@ }; +&hdmi { + hdmi-supply = <®_dldo1>; + status = "okay"; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + &i2c1 { pinctrl-names = "default"; pinctrl-0 = <&i2c1_pins>;@@ -99,6 +125,10 @@ }; }; +&mixer1 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>;@@ -238,6 +268,10 @@ status = "disabled"; }; +&tcon1 { + status = "okay"; +};Is it working or not on the pine64?Not tested yet, as my main A64 device is Pine A64-LTS now.It was last reported as broken, so it's better to leave it out of that patch until someone figures it out.Sorry, I did find a bug. Although after fixing it HDMI on Pine A64+ works fine. Will fix the bug when sending v3.2 (resending after rc1).
Why don't you simply send v4, with all patches and changelogs? It would be easier to comprehend. Best regards, Jernej
quoted
Thanks! Maxime