Thread (85 messages) 85 messages, 5 authors, 2018-07-26

[PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan()

From: miquel.raynal@bootlin.com (Miquel Raynal)
Date: 2018-07-25 12:47:32
Also in: linux-mediatek, lkml

Hi Boris,

Boris Brezillon [off-list ref] wrote on Wed, 25 Jul 2018
11:51:16 +0200:
On Wed, 25 Jul 2018 18:42:44 +0900
Masahiro Yamada [off-list ref] wrote:
quoted
You need to remove kfree(denali->buf)
from denali_remove(), right?  
Absolutely.
quoted
void denali_remove(struct denali_nand_info *denali)
{
        struct mtd_info *mtd = nand_to_mtd(&denali->nand);

        nand_release(mtd);
        kfree(denali->buf);       <---- REMOVE !!
        denali_disable_irq(denali);
}


Otherwise, denali_remove() will free denali->buf twice
because kfree(denali->buf) is called from denali_detach_chip().  
Absolutely, thanks for reviewing!

I'll apply with this changed.

Miqu?l
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help