Thread (29 messages) 29 messages, 6 authors, 2018-07-20

[PATCH 2/5] net: add an info message to eth_platform_get_mac_address()

From: davem@davemloft.net (David Miller)
Date: 2018-07-18 23:13:05
Also in: linux-omap, lkml, netdev

From: Bartosz Golaszewski <redacted>
Date: Wed, 18 Jul 2018 18:10:32 +0200
 
+	dev_info(dev, "read MAC address from %s\n", from);
 	ether_addr_copy(mac_addr, addr);
 	return 0;
Ugh, please don't do this.

We probe various bits of information from various sources during
driver probe, and none of them are more or less important than
the MAC address.  So singling this out for log info output is
really not such a great idea.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help