Thread (29 messages) 29 messages, 6 authors, 2018-07-20

[PATCH 5/5] net: add MTD support to eth_platform_get_mac_address()

From: andrew@lunn.ch (Andrew Lunn)
Date: 2018-07-18 17:04:19
Also in: linux-omap, lkml, netdev

quoted
quoted
+#ifdef CONFIG_MTD
+     /* NOTE: this should go away as soon as MTD gets nvmem support. */
+     if (!addr) {
+             struct mtd_info *mtd;
+             int rv;
+
+             mtd = get_mtd_device_nm("MAC-Address");
In order for this to go away, you need to keep backwards
compatibility. When using nvmem, you look for a cell called
"mac-address". Here you are looking for "MAC-Address". That is going
to make backwards compatibility harder. How do you plan to do it?

   Andrew
I'm trying to adjust to already existing users. The only user of
get_mtd_device_nm() who calls it to read the MAC address registers a
partition called "MAC-Address". We can't change it since it's visible
from user space. In the future we'd just have to have a list of
supported string that we'd use to do the nvmem lookup.
Why not have the nvmem cell called "MAC-Address"? When you add nvmem
support to MTD, i assume you are going to map each MTD partition to an
nvmem cell?

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help