[PATCH] arm64: Clear the stack

From
Laura Abbott <hidden>
Date
2018-07-17 22:58:26
Also in
lkml
Reply to
Mark Rutland, 2018-07-03
On 07/03/2018 05:14 AM, Mark Rutland wrote:
quoted
It might be cleaner just to use on_accessible_stack and then another
function to get the top of stack. This also might just be
reimplementing what x86 already has? (Mark, Ard?)
It looks like we could build a get_stack_info() as they have.

We could probably clean up our stack traced atop of that, too.
So I spent some time looking at this and I'm not 100% clear
if there would actually be much benefit to re-writing with
get_stack_info. Most of that design seems to come from x86
needing to handle multiple unwind options which arm64 doesn't
need to worry about. Any rework ended up with roughly
the same code without any notable benefit that I could see.
It's possible I'm missing what kind of cleanup you're suggesting
but I think just going with a tweaked version of on_accessible_stack
would be fine.

Thanks,
Laura
Thread (17 messages) 17 messages, 6 authors, last reply 2018-07-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help