On Thu, Jul 12, 2018 at 3:30 AM Doug Anderson [off-list ref] wrote:

Hi Matthias,

On Wed, Jul 11, 2018 at 2:51 PM, Matthias Kaehlcke [off-list ref] wrote:

quoted

On Wed, Jul 11, 2018 at 11:44:13AM -0700, Doug Anderson wrote:

quoted

Hi,

On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria [off-list ref] wrote:

quoted

SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors. It uses version 2 of the TSENS IP, so use the fallback property to
allow more common code.

Signed-off-by: Amit Kucheria <redacted>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index cdaabeb..ba2899c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi

@@ -221,6 +221,22 @@
                        #interrupt-cells = <2>;
                };

+               tsens0: tsens at c263000 {

As per my comments in the bindings, nit that this should probably be
"thermal-sensor" not "tsens", AKA:

tsens0: thermal-sensor at c263000 {

Fixed.

quoted

quoted

quoted

+                       compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
+                       reg = <0xc263000 0x1ff>, /* TM */
+                             <0xc222000 0x1ff>; /* SROT */
+                       #qcom,sensors = <13>;

As per my comment in the bindings and the code, I'm confused about the
whole "#qcom,sensors" bit.  It's not documented and doesn't seem
hooked up in the code either.

...but if people have tested this, perhaps I'm confused.  How can
things work if num_sensors is 0???

The mystery is resolved by:

commit 6d7c70d1cd6526dc79e3d3b3faae1c40c1681168
Author: Bjorn Andersson [off-list ref]
Date:   Mon May 7 16:53:39 2018 -0700

    thermal: qcom: tsens: Allow number of sensors to come from DT

    For platforms that has multiple copies of the TSENS hardware block it's
    necessary to be able to specify the number of sensors per block in DeviceTree.

    Signed-off-by: Bjorn Andersson [off-list ref]
    Reviewed-by: Amit Kucheria [off-list ref]
    Reviewed-by: Rob Herring [off-list ref]
    Signed-off-by: Eduardo Valentin [off-list ref]


I bumped into this during testing ;-)

I think this was merged in 4.17, so you didn't see it in your tree :-)

Ah, now it makes sense to me!  Serves me right for assuming it would
be in the same series and not checking if it was something that had
already landed.  Thanks.  Please ignore the parts of my comments
related to the "#qcom,sensors" property.  I guess Rob must have
thought that the "#" in the name was fine and he's the one in charge
not me.

Thanks for your review, Doug. I'll test this and post a v7 today. I'd
really like to get this accepted for 4.19 so I can post interrupt
support and some more cleanups.

Regards,
Amit