[PATCH v6 7/7] arm64: dts: sdm845: Add tsens nodes
From: dianders@chromium.org (Doug Anderson)
Date: 2018-07-11 18:44:19
Also in:
linux-arm-msm, linux-devicetree, lkml
Hi, On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria [off-list ref] wrote:
quoted hunk ↗ jump to hunk
SDM845 has two tsens blocks, one with 13 sensors and the other with 8 sensors. It uses version 2 of the TSENS IP, so use the fallback property to allow more common code. Signed-off-by: Amit Kucheria <redacted> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index cdaabeb..ba2899c 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi@@ -221,6 +221,22 @@ #interrupt-cells = <2>; }; + tsens0: tsens at c263000 {
As per my comments in the bindings, nit that this should probably be
"thermal-sensor" not "tsens", AKA:
tsens0: thermal-sensor at c263000 {
+ compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; + reg = <0xc263000 0x1ff>, /* TM */ + <0xc222000 0x1ff>; /* SROT */ + #qcom,sensors = <13>;
As per my comment in the bindings and the code, I'm confused about the whole "#qcom,sensors" bit. It's not documented and doesn't seem hooked up in the code either. ...but if people have tested this, perhaps I'm confused. How can things work if num_sensors is 0??? -Doug