Hi Andreas,

On Sat, Jun 30, 2018 at 02:23:30PM +0200, Andreas F?rber wrote:

Am 28.06.2018 um 20:10 schrieb Manivannan Sadhasivam:

quoted

Add devicetree binding for Actions Semi OWL I2C controller

Signed-off-by: Manivannan Sadhasivam <redacted>
---
 .../devicetree/bindings/i2c/i2c-owl.txt       | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt

diff --git a/Documentation/devicetree/bindings/i2c/i2c-owl.txt b/Documentation/devicetree/bindings/i2c/i2c-owl.txt
new file mode 100644
index 000000000000..9b691968cffd
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-owl.txt

@@ -0,0 +1,27 @@
+OWL I2C controller

As mentioned elsewhere, please fix all subjects, commit messages and
bindings to say Owl, not OWL. There's no need to upper-case it besides
defines.

Also, this title should mention Actions Semiconductor please, not just
the codename Owl.

Sure

quoted

+
+Required properties:
+
+- compatible        : Should be "actions,s900-i2c".

What about S500? Are you expecting it to carry an S900 compatible? That
seems strange. Are there any differences in the implementations?

I haven't tested it on S500 eventhough the implementation looks same. But
anyway if we want to add support for S500 or S700 we can just do the
modifications (if any) slightly and add a separate compatible like we
did for other drivers.

Thanks,
Mani

Otherwise looks okay.

Thanks,
Andreas

quoted

+- reg               : Offset and length of the register set for the device.
+- #address-cells    : Should be 1.
+- #size-cells       : Should be 0.
+- interrupts        : A single interrupt specifier.
+- clocks            : Phandle of the clock feeding the I2C controller.
+
+Optional properties:
+
+- clock-frequency   : Desired I2C bus clock frequency in Hz. As only Normal and
+                      Fast modes are supported, possible values are 100000 and
+                      400000.
+Examples:
+
+        i2c0: i2c at e0170000 {
+                compatible = "actions,s900-i2c";
+                reg = <0 0xe0170000 0 0x1000>;
+                #address-cells = <1>;
+                #size-cells = <0>;
+                interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+                clocks = <&clock CLK_I2C0>;
+                clock-frequency = <100000>;
+        };

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)