[PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name

-----Original Message-----
From: Joe Perches [mailto:joe at perches.com]
Sent: Wednesday, June 20, 2018 4:08 AM
To: Andy Shevchenko <redacted>; Radhey Shyam
Pandey [off-list ref]
Cc: David S. Miller <davem@davemloft.net>; Andrew Lunn
[off-list ref]; Michal Simek [off-list ref]; netdev
[off-list ref]; linux-arm Mailing List <linux-arm-
kernel at lists.infradead.org>; Linux Kernel Mailing List <linux-
kernel at vger.kernel.org>
Subject: Re: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded
name

On Wed, 2018-06-20 at 00:36 +0300, Andy Shevchenko wrote:

quoted

On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey
[off-list ref] wrote:

quoted

Switch hardcoded function name with a reference to __func__ making
the code more maintainable. Address below checkpatch warning:

WARNING: Prefer using '"%s...", __func__' to using

'xemaclite_mdio_read',

quoted

quoted

this function's name, in a string
+               "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",

WARNING: Prefer using '"%s...", __func__' to using

'xemaclite_mdio_write',

quoted

quoted

this function's name, in a string
+               "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n",

For dev_dbg() the __func__ should be completely dropped away.

Not really the same.

dev_dbg without CONFIG_DYNAMIC_DEBUG does not have
the ability to prefix __func__.

Yes.  If it's acceptable,  prefer to use __func__  to support all 
configurations