Thread (9 messages) flat view 9 messages, 4 authors, 2018-06-25

[PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name

From: Andy Shevchenko <hidden>
Date: 2018-06-19 21:37:03
Also in: lkml, netdev

On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey
[off-list ref] wrote:
Switch hardcoded function name with a reference to __func__ making
the code more maintainable. Address below checkpatch warning:

WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read',
this function's name, in a string
+               "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",

WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write',
this function's name, in a string
+               "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n",
For dev_dbg() the __func__ should be completely dropped away.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help