Thread (7 messages) 7 messages, 4 authors, 2018-06-28

[PATCH] arm64: dts: hikey: Define wl1835 power capabilities

From: Ryan Grachek <hidden>
Date: 2018-06-13 18:19:58
Also in: linux-devicetree, lkml

Hi Valentin,

On Wed, Jun 13, 2018 at 12:34 PM, Valentin Schneider
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Hi,

On 13/06/18 16:13, Ryan Grachek wrote:
quoted
These properties are required for compatibility with runtime PM.
Without these properties, MMC host controller will not be aware
of power capabilities. When the wlcore driver attempts to power
on the device, it will erroneously fail with -EACCES.
I don't have a hikey620 to test this, but the hikey960 is suffering from the
same issue (see [1]). I added these properties to the dwmmc2 node of the
hikey960 (see snippet) and wlan0 does show up. Would you mind sending a
similar patch for that board ?

Thanks !

Valentin

[1]: https://lkml.org/lkml/2018/6/12/930

--->8
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 85aadf1b..c706f70 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -613,6 +613,8 @@
        vmmc-supply = <&wlan_en>;
        ti,non-removable;
        non-removable;
+       cap-power-off-card;
+       keep-power-in-suspend;
        #address-cells = <0x1>;
        #size-cells = <0x0>;
        status = "ok";
Not a problem. The patch can be found here:
https://patchwork.kernel.org/patch/10462767/

Ryan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help