2018-06-04 9:08 GMT+09:00 Katsuhiro Suzuki [off-list ref]:

Hello Yamada-san,

quoted

-----Original Message-----
From: Masahiro Yamada <redacted>
Sent: Saturday, June 2, 2018 9:00 PM
To: Suzuki, Katsuhiro/?? ?? <redacted>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
linux-media at vger.kernel.org; Masami Hiramatsu [off-list ref];
Jassi Brar [off-list ref]; linux-arm-kernel
[off-list ref]; Linux Kernel Mailing List
[off-list ref]
Subject: Re: [PATCH 6/8] media: uniphier: add common module of DVB adapter drivers

2018-05-30 18:09 GMT+09:00 Katsuhiro Suzuki [off-list ref]:

quoted

This patch adds common module for UniPhier DVB adapter drivers
that equipments tuners and demod that connected by I2C and
UniPhier demux.

Signed-off-by: Katsuhiro Suzuki <redacted>
---
 drivers/media/platform/uniphier/Makefile      |  5 ++
 drivers/media/platform/uniphier/hsc-core.c    |  8 ---
 .../platform/uniphier/uniphier-adapter.c      | 54 +++++++++++++++++++
 .../platform/uniphier/uniphier-adapter.h      | 42 +++++++++++++++
 4 files changed, 101 insertions(+), 8 deletions(-)
 create mode 100644 drivers/media/platform/uniphier/uniphier-adapter.c
 create mode 100644 drivers/media/platform/uniphier/uniphier-adapter.h

diff --git a/drivers/media/platform/uniphier/Makefile

b/drivers/media/platform/uniphier/Makefile

quoted

index 0622f04d9e68..9e75ad081b77 100644

--- a/drivers/media/platform/uniphier/Makefile
+++ b/drivers/media/platform/uniphier/Makefile

@@ -3,3 +3,8 @@ uniphier-dvb-y += hsc-core.o hsc-ucode.o hsc-css.o hsc-ts.o

hsc-dma.o

quoted

 uniphier-dvb-$(CONFIG_DVB_UNIPHIER_LD11) += hsc-ld11.o

 obj-$(CONFIG_DVB_UNIPHIER) += uniphier-dvb.o
+
+ccflags-y += -Idrivers/media/dvb-frontends/
+ccflags-y += -Idrivers/media/tuners/

Please add $(srctree)/ like

ccflags-y += -I$(srctree)/drivers/media/dvb-frontends/
ccflags-y += -I$(srctree)/drivers/media/tuners/


Currently, it works $(srctree)/,
but I really want to rip off the build system hack.

Thanks, I agree with your opinion, but other Makefiles in drivers/media use
same hack. I don't know other way to include headers of demodulators and
tuners...

Do you have any good ideas?

My suggestion is to add '$(srctree)/'.

For clarification,



Bad:

ccflags-y += -Idrivers/media/dvb-frontends/
ccflags-y += -Idrivers/media/tuners/



Good:

ccflags-y += -I$(srctree)/drivers/media/dvb-frontends/
ccflags-y += -I$(srctree)/drivers/media/tuners/





I want to fix this tree-wide,
then remove the 'addtree' from scripts/Kbuild.include
but I have not been able to find time for that.

This is a new file, so just suggested to add '$(srctree)/'



If you want to know the context:
https://patchwork.kernel.org/patch/9632347/


-- 
Best Regards
Masahiro Yamada