On Thu, May 17, 2018 at 11:01:57AM +0300, Gilad Ben-Yossef wrote:

On Wed, May 16, 2018 at 10:43 AM, Simon Horman [off-list ref] wrote:

quoted

On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote:

quoted

Hi Gilad,

On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef [off-list ref] wrote:

quoted

Add bindings for CryptoCell instance in the SoC.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thanks for your patch!

quoted

--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi

@@ -528,6 +528,14 @@
                        status = "disabled";
                };

+               arm_cc630p: crypto at e6601000 {
+                       compatible = "arm,cryptocell-630p-ree";
+                       interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
+                       #interrupt-cells = <2>;

I believe the #interrupt-cells property is not needed.

quoted

+                       reg = <0x0 0xe6601000 0 0x1000>;
+                       clocks = <&cpg CPG_MOD 229>;
+               };

The rest looks good, but I cannot verify the register block.

quoted

+
                i2c3: i2c at e66d0000 {
                        #address-cells = <1>;
                        #size-cells = <0>;

Thanks, I have applied this after dropping the #interrupt-cells property.

Thanks you!

Alas, it will not work without the clk patch (the previous one in the
series) so they need to be
taken or dropped together.

I think its fine if it does not yet work.
But not if its causes things that previously worked to stop working.