-----Original Message-----
From: Viresh Kumar <viresh.kumar@linaro.org>
Sent: Wednesday, May 16, 2018 17:12
To: Amit Kucheria <redacted>
Cc: Ilia Lin <redacted>; Michael Turquette
[off-list ref]; sboyd at kernel.org; Rob Herring
[off-list ref]; Mark Rutland [off-list ref]; nm at ti.com;
lgirdwood at gmail.com; broonie at kernel.org; Andy Gross
[off-list ref]; David Brown [off-list ref];
catalin.marinas at arm.com; will.deacon at arm.com; Rafael J. Wysocki
[off-list ref]; linux-clk at vger.kernel.org;
devicetree at vger.kernel.org; LKML [off-list ref]; Linux
PM list [off-list ref]; linux-arm-msm at vger.kernel.org; linux-
soc at vger.kernel.org; lakml [off-list ref];
Rajendra Nayak [off-list ref]; nicolas.dechesne at linaro.org;
celster at codeaurora.org; tfinkel at codeaurora.org
Subject: Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

On 16-05-18, 16:12, Amit Kucheria wrote:

quoted

quoted

+       ret = PTR_ERR_OR_ZERO(opp_temp =
+

dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));

quoted

quoted

+       if (0 > ret)

Any particular reason to prefer this over (ret < 0) that is generally
used? I've seen it used to avoid the == vs. = typos, but not for other
comparisons.

Suggest sticking to what is commonly used i.e. ret < 0.

quoted

+               goto free_opp;
+
+       cpu_dev = get_cpu_device(GOLD_LEAD);

Error check cpu_dev here?

quoted

+       ret = PTR_ERR_OR_ZERO(opp_temp =
+

dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));

quoted

quoted

+       if (0 > ret)
+               goto free_opp;

The goto here is wrong

If we are here, then the first dev_pm_opp_set_supported_hw() succeeded. And
should be deallocated before exit with error.

quoted

quoted

+
+
+       ret =

PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt",

quoted

quoted

+                                                             -1,
+ NULL, 0));
+
+       if (0 == ret)
+               return 0;
+
+free_opp:
+       dev_pm_opp_put_supported_hw(opp_temp);

This is not needed because dev_pm_opp_set_supported_hw will free
memory in case of failure. This call in only needed in case of a
successful get.

But this is still required for the case where platform device registration

fails.

--
viresh