Thread (6 messages) 6 messages, 3 authors, 2018-03-20

[PATCH] serial: mvebu-uart: fix tx lost characters

From: gregkh@linuxfoundation.org (gregkh at linuxfoundation.org)
Date: 2018-03-20 09:32:10
Also in: linux-serial, stable

On Fri, Mar 16, 2018 at 01:45:32PM +0000, Gabriel Matni wrote:
From: Gabriel Matni <redacted>

Fixes missing characters on kernel console at low baud rates (i.e.9600).
The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
that the transmitter holding register (THR) is ready to receive a new byte.

TX_EMP tells us when it is possible to send a break sequence via
SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
empty, it does not guarantee that a new byte can be written just yet.

Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700
      serial port")
Can all be on one line.

And should this go to the stable trees?
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> 
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>  
Signed-off-by: Gabriel Matni <redacted> 
Trailing whitespace?
---
 drivers/tty/serial/mvebu-uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
What version of this patch is this?  How do I know which to accept?

Please properly version your patch, and include the changes below the
--- line like the documentation says to do.
thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help