Thread (76 messages) 76 messages, 3 authors, 2018-03-17

[PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

From: Archit Taneja <hidden>
Date: 2018-03-14 06:33:54
Also in: dri-devel, linux-input, linux-rockchip, linux-samsung-soc, lkml


On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote:
From: zain wang <redacted>

The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable,
so we may hit the error log "Timeout of video streamclk ok" since
checked this unstable bit.
In fact, we can go continue and the streamclk is ok if we wait enough time,
it does no effect on display.
Let's change this error to warn.
Reviewed-by: Archit Taneja <redacted>

Thanks,
Archit
quoted hunk ↗ jump to hunk
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: zain wang <redacted>
Signed-off-by: Sean Paul <redacted>
Signed-off-by: Thierry Escande <redacted>
Reviewed-by: Andrzej Hajda <redacted>
Signed-off-by: Enric Balletbo i Serra <redacted>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---

  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 1f1cb624414d..d76e1652b1fd 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -921,8 +921,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp)
  			done_count = 0;
  		}
  		if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) {
-			dev_err(dp->dev, "Timeout of video streamclk ok\n");
-			return -ETIMEDOUT;
+			dev_warn(dp->dev,
+				 "Ignoring timeout of video streamclk ok\n");
+			break;
  		}
  
  		usleep_range(1000, 1001);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help