On 02/18/2018 04:08 PM, Rob Herring wrote:

On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote:

quoted

watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.

By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.

Same problems in this one.

Same answer. In the existing driver;

         mtk_wdt->wdt_dev.timeout = WDT_MAX_TIMEOUT;

Guenter

quoted

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++++
  drivers/watchdog/mtk_wdt.c                             | 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)