[PATCH v2 09/12] ARM: dts: STi: Add fake reg property for sound related nodes
From: robh@kernel.org (Rob Herring)
Date: 2018-02-12 15:41:08
Also in:
linux-devicetree, lkml
On Mon, Feb 12, 2018 at 8:43 AM, [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Patrice Chotard <redacted> Add fake reg property to sound, simple-audio-card, dai-link and sti_sasg_codec nodes, this allows to fix the following warning when compiling dtb with W=1 option: arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 0 has a unit name, but no reg property arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 1 has a unit name, but no reg property arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 2 has a unit name, but no reg property arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): Node /soc/sti-sasg-codec missing or empty reg/ranges property arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 0 has a unit name, but no reg property arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 1 has a unit name, but no reg property arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 2 has a unit name, but no reg property arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg): Node /soc/sound missing or empty reg/ranges property arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): Node /soc/sti-sasg-codec missing or empty reg/ranges property arch/arm/boot/dts/stih410-b2260.dtb: Warning (unit_address_vs_reg): Node /soc/sound/simple-audio-card,dai-link at 0 has a unit name, but no reg property arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): Node /soc/sti-sasg-codec missing or empty reg/ranges property arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): Node /soc/sound missing or empty reg/ranges property arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): Node /soc/sti-sasg-codec missing or empty reg/ranges property Signed-off-by: Patrice Chotard <redacted> --- v2: _ add a fake reg property to node without reg property. arch/arm/boot/dts/stih407-family.dtsi | 3 ++- arch/arm/boot/dts/stih410-b2260.dts | 5 +++-- arch/arm/boot/dts/stihxxx-b2120.dtsi | 11 ++++++----- 3 files changed, 11 insertions(+), 8 deletions(-)diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index 5df827b00eb6..df1a3f1dc5a7 100644 --- a/arch/arm/boot/dts/stih407-family.dtsi +++ b/arch/arm/boot/dts/stih407-family.dtsi@@ -894,8 +894,9 @@ status = "disabled"; }; - sti_sasg_codec: sti-sasg-codec { + sti_sasg_codec: sti-sasg-codec at 0 { compatible = "st,stih407-sas-codec"; + reg = <0 0>; #sound-dai-cells = <1>; status = "disabled"; st,syscfg = <&syscfg_core>;
This should probably be a child of syscfg to fix this. And if this block has a dedicated set of registers, then use reg to define those (even though regmap/syscon doesn't need it).
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts index 8bcd58118dba..03d05a98b7fc 100644 --- a/arch/arm/boot/dts/stih410-b2260.dts +++ b/arch/arm/boot/dts/stih410-b2260.dts@@ -181,12 +181,13 @@ status = "okay"; }; - sound { + sound: sound at 0 {
I'd move this up to top level. Rob