PM regression in next
From: broonie@kernel.org (Mark Brown)
Date: 2018-01-12 23:00:10
Also in:
linux-omap, linux-pm, lkml
On Fri, Jan 12, 2018 at 02:49:59PM -0800, Tony Lindgren wrote:
* Mark Brown [off-list ref] [180112 22:11]:
quoted
Most devices have one regmap per device which can be retrieved with dev_get_regmap(), it's the attempt to use that which I suspect is broken. Like I said snd_soc_codec_init_regmap() ought to fix things if that's the issue.
OK. Adding Peter to loop as it's his driver after all. Not sure how well mixing regmap register access to the same module with cached twl4030_read() would work :)
Yes, that local cache is not a super good idea any more and hopefully redundant.
Maybe there should also be some big warning happening if snd_soc_codec_init_regmap() is now needed and no regmap is found?
Some devices just plain don't have registers at all (perhaps GPIOs or just stub drivers providing capability information). However we should be screaming loudly about the fact that the I/O we tried to do fails, that clearly shouldn't be being ignored. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180112/170fff1f/attachment.sig>