[PATCH 00/12] Marvell NAND controller rework with ->exec_op()

Hi Robert,

On Sat, 23 Dec 2017 14:42:20 +0100
Robert Jarzmik [off-list ref] wrote:

Miquel RAYNAL [off-list ref] writes:

I removed a lot of people from the recipients, as this is a debug
session.

Sure!

quoted

quoted

quoted

Now I get a lot of these message which I didn't have before :
[   26.897372] ubi0 warning: ubi_io_read: error -74 (ECC error)
while reading 126976 bytes from PEB 242:4096, read only 126976  

Looks like a mismatch in the ECC config. Can you check the ecc
strength/step_size in both situation (old driver vs new driver)?  

For that, you might want to add traces in marvell_nand_ecc_init()
and marvell_nand_hw_ecc_ctrl_init().
 

quoted

Could you also dump the NDCR register in both cases?  

NDCR register (as well as NDCBx registers) will appear if you let

    #define DEBUG

at the beginning of the driver.

Also, can you please give us the entire dmesg (I mean the boot, not
the flow of UBIFS errors of course).  

Here it comes in [3]. I suspect the BBT parser here, here is the
extract that _might_ be relevant:
[    3.372907] nand: ->exec_op() parser: pattern not found!

Indeed this might be the problem, it means there is one scenario that
should be handled by the parser that is missing. I am really
interrogative about which one it is and to discover it, can you rebuild
with

        #define DEBUG

in drivers/mtd/nand/nand_base.c too.

This way the core will display the patterns it try to find a match for.

Also to ease the understanding, you might add a dump_stack() right
next to this error message.

[    3.378445] marvell-nfc pxa3xx-nand: 
... repeats many times ...
[    3.666571] Bad block table not found for chip 0
[    3.671368] Scanning device for bad blocks
[    3.675540] nand: nand_do_read_oob: from = 0x00000000, len = 64
[    3.681688] marvell-nfc pxa3xx-nand: 
[    3.681688] NDCR:  0x9d079fff
[    3.681688] NDCB0: 0x000d3000
[    3.681688] NDCB1: 0x00000000
[    3.681688] NDCB2: 0x00000000
[    3.681688] NDCB3: 0x00000000
[    3.700570] Bad eraseblock 0 at 0x000000000000

My configuration is :
 - make zylonite_defconfig
 - apply patch in [1] for arch/arm/mach-pxa
 - apply patch in [2] for drivers/mtd
 - run the test (make zylonite_defconfig; make;
do_the_test_with_jenkins) That should give you all my setup
information, ie. platform_data, ECC and BBT settings (ie. the
"MBBbt0" pattern).

This is probably a typo, because we expect the pattern to be "MVBbt0"?

Cheers.

Thanks for the help,
Miqu?l


-- 
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com