Thread (10 messages) 10 messages, 5 authors, 2017-12-12

[PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

From: Philippe Ombredanne <hidden>
Date: 2017-12-12 09:15:43
Also in: linux-devicetree, lkml, netdev

Dear Masami-san,

On Tue, Dec 12, 2017 at 3:29 AM, Masami Hiramatsu
[off-list ref] wrote:
[...]
Then what I'm considering is copyright notice lines. Those are usually
treat as the header lines, not single line. So
quoted
+// SDPX-License-Identifier: GPL-2.0
+// sni_ave.c - Socionext UniPhier AVE ethernet driver
+// Copyright 2014 Panasonic Corporation
+// Copyright 2015-2017 Socionext Inc.
is acceptable? or should we keep C-style header lines for new drivers?
quoted
+// SDPX-License-Identifier: GPL-2.0
+/*
+ * sni_ave.c - Socionext UniPhier AVE ethernet driver
+ * Copyright 2014 Panasonic Corporation
+ * Copyright 2015-2017 Socionext Inc.
+ */
I just concern that those lines are not "single". that's all. :)
My voice carries the weight of a down feather in this discussion and
to me the benefit of the first form is that you have removed two
lines. Both forms work fine.

-- 
Cordially
Philippe Ombredanne
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help