[PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

Hello Lukasz,

On Wed, 29 Nov 2017 23:07:04 +0100
Lukasz Majewski [off-list ref] wrote:

quoted

quoted

+/*************************************************************************
+ * BK3 support code
+
*************************************************************************/
+static struct mtd_partition bk3_nand_parts[] = {
+	{
+		.name		= "System",
+		.offset	= 0x00000000,  

I see the above and below lines as unaligned

This is strange.... I'm using emacs with extension to have coding style
for kernel.

Probably tabs get unaligned...

Yes, seems that they are.

[...]

quoted

quoted

+	.atag_offset	= 0x100,
+	.map_io	= bk3_map_io,  

again, inconsistent alignment...

Even more..... checkpatch.pl did not complained....

checkpatch.pl wouldn't complain, as there are basically two styles,
some people do not align the individual assignments in the structures at all.
But I was quite confident in the beginning and now even applied your v3 to
the code. And indeed it's unaligned... I even checked with emacs. Still
unaligned.

-- 
Alexander Sverdlin.