Thread (34 messages) 34 messages, 4 authors, 2017-11-24

[PATCH V2 24/29] backlight: deprecate pci_get_bus_and_slot()

From: Daniel Thompson <hidden>
Date: 2017-11-23 12:11:24
Also in: linux-arm-msm, linux-fbdev, linux-pci, lkml


On 22/11/17 22:49, Sinan Kaya wrote:
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.

Getting ready to remove pci_get_bus_and_slot() function in favor of
pci_get_domain_bus_and_slot().

Hard-coding the domain as 0.

Signed-off-by: Sinan Kaya <redacted>
I've no opinion on the wisdom or otherwise of removing the restrictive 
API but, providing the removal of that API from the header file collects 
the appropriate ack, then:

Acked-by: Daniel Thompson <redacted>

quoted hunk ↗ jump to hunk
---
  drivers/video/backlight/apple_bl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/apple_bl.c b/drivers/video/backlight/apple_bl.c
index d843296..6a34ab9 100644
--- a/drivers/video/backlight/apple_bl.c
+++ b/drivers/video/backlight/apple_bl.c
@@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev)
  	struct pci_dev *host;
  	int intensity;
  
-	host = pci_get_bus_and_slot(0, 0);
+	host = pci_get_domain_bus_and_slot(0, 0, 0);
  
  	if (!host) {
  		pr_err("unable to find PCI host\n");
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help