On 29/09/17 22:43, Heiner Kallweit wrote:

I do not see a benefit in using drvdata as variable scpi_info is
available everywhere anyway.

I will reword above before committing as:
"There's no benefit using drvdata as variable scpi_info is global"

And setting scpi_info to NULL in scpi_remove isn't needed IMO.
If arm_scpi is built-in, then this code is never used. And if arm_scpi
is built as a module and some other module calls get_scpi_ops() then
due to this dependency scpi_remove is called only after the other
module has been removed. Last but not least users usually store the
result of get_scpi_ops(), therefore setting scpi_info to NULL wouldn't
really help.

Agreed. I am fine with the change. Only issue I see is to support
multiple instances of SCPI on a platform, but that may need more rework
anyways.

-- 
Regards,
Sudeep