On Wed, Oct 4, 2017 at 2:58 PM, Andrew Jeffery [off-list ref] wrote:

On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:

quoted

-                     uart6: serial at 1e787000 {
-                             compatible = "ns16550a";
-                             reg = <0x1e787000 0x1000>;
+                     vuart: vuart at 1e787000 {

Bit of a nit, but arguably this should be `vuart: serial at ...`?

Yep, that makes sense.

quoted

+                             compatible = "aspeed,ast2400-vuart";
+                             reg = <0x1e787000 0x40>;
                              reg-shift = <2>;
                              interrupts = <10>;
                              clocks = <&clk_uart>;

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 251fc9f4637e..0b793305120a 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi

quoted

@@ -287,9 +278,19 @@
                              };
                      };

+                     uart1: serial at 1e783000 {

Earlier in the series you had a patch moving the ADC node to be in
address-order with respect to the rest of the nodes but this change puts uart1
out of address-order. As it turns out the uarts blocks are sprayed around in
the address-space: uart1 and uart5 are together, the vuart is elsewhere, then
uarts 2-4 are lumped together in another spot. I think it makes sense to
consolidate them, but it is inconsistent. Thoughts?

Yeah. I'll move them to where they should be.

Cheers,

Joel