Thread (12 messages) 12 messages, 2 authors, 2017-09-21

[PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

From: Uwe Kleine-König <hidden>
Date: 2017-09-21 18:15:16
Also in: linux-serial, lkml

On Thu, Sep 21, 2017 at 05:18:13PM +0100, Martyn Welch wrote:
From: Romain Perier <redacted>

The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int().
This is problematic as:

- whilst imx_disable_rx_int() is currently always called before
  start_rx_dma() this dependency isn't obvious.
- start_rx_dma() does error checking and might exit without
  enabling DMA. Currently this will result in dma_is_rxing suggesting
  that DMA is being used for recieving.

To avoid these issues, move the setting of dma_is_rxing to
start_rx_dma() when appropriate.

Signed-off-by: Romain Perier <redacted>
Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>
Reviewed-by: Uwe Kleine-K?nig <redacted>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help