[PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

From
Chen-Yu Tsai <hidden>
Date
2017-09-08 07:39:35
Also in
linux-devicetree, lkml, netdev
Reply to
Corentin Labbe, 2017-09-08
On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe
[off-list ref] wrote:
On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote:
quoted
On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:
quoted
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
index 1c2387bd5df6..968908761194 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
@@ -50,6 +50,7 @@
    compatible = "friendlyarm,nanopi-neo2", "allwinner,sun50i-h5";

    aliases {
+           ethernet0 = &emac;
            serial0 = &uart0;
    };
@@ -108,6 +109,22 @@
    status = "okay";
 };

+&emac {
+   pinctrl-names = "default";
+   pinctrl-0 = <&emac_rgmii_pins>;
+   phy-supply = <&reg_gmac_3v3>;
+   phy-handle = <&ext_rgmii_phy>;
+   phy-mode = "rgmii";
+   status = "okay";
+};
+
+&mdio {
+   ext_rgmii_phy: ethernet-phy at 7 {
+           compatible = "ethernet-phy-ieee802.3-c22";
+           reg = <7>;
+   };
+};
+
This won't compile, you don't have that node in the H5 DTSI.
Since H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles.
Furthermore, I restested just now and confirm, it compiles fine.
The order of your patches are wrong. No individual patch should
introduce build failures, not just the whole patch series.

ChenYu
Thread (35 messages) 35 messages, 5 authors, last reply 2017-09-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help