[PATCH v2 05/18] firmware: arm_scmi: add initial support for performance protocol
From: Sudeep Holla <hidden>
Date: 2017-09-05 16:54:11
Also in:
linux-devicetree, lkml
From: Sudeep Holla <hidden>
Date: 2017-09-05 16:54:11
Also in:
linux-devicetree, lkml
Hi Julien, On 05/09/17 16:56, Julien Thierry wrote:
On 05/09/17 16:04, Julien Thierry wrote:
[...]
quoted
This seems odd, shouldn't it be the following? le64_to_cpu(attr->stats_addr_low | (__le64)attr->stats_addr_high << 32)After further reflexion, I think you are right. If I understood the specification, the address seems to be split into upper and lower 32bits and each one is stored as a uint32, which fits what you are doing to obtain the address. You can ignore my previous comment.
Sorry I am checking this bit late, you have figured out yourself already. All the 64 bit values need to be dealt similarly as SCMI specification restricts so. It's basically done so as the firmware running is mostly 32-bit little endian system. -- Regards, Sudeep