On Tue, Aug 29, 2017 at 03:38:52PM +0200, Lukas Wunner wrote:

On Tue, Aug 29, 2017 at 04:28:53PM +0300, Mathias Nyman wrote:

quoted

Then again it might be a bit too drastic to kill xhci just because
we read 0xffffffff once from a mmio xhci register. Maybe we should
return an error a couple times before actually tearing down xhci.

This tight check was originally done to detect pci hotplug removed
hosts as soon as possible.

Just make pci_dev_is_disconnected() public to detect PCI hot removal.
We *know* when the device was hot removed, so I think there's no need
to guess that based on reading "all ones" from mmio (which may happen
for entirely legitimate reasons unrelated to hot removal).

No, you don't always "know" when a device is removed, don't rely on it,
not all platforms support that.

One more reason why I hate that function and I'm glad it's not exported
for others to think it somehow actually works for their system...

Reading all ff shows the device is removed, that's all the PCI spec
guarantees.  What other legitimate reason could that happen for?

thanks,

greg k-h