On Tue, Aug 29, 2017 at 04:28:53PM +0300, Mathias Nyman wrote:

Then again it might be a bit too drastic to kill xhci just because
we read 0xffffffff once from a mmio xhci register. Maybe we should
return an error a couple times before actually tearing down xhci.

This tight check was originally done to detect pci hotplug removed
hosts as soon as possible.

Just make pci_dev_is_disconnected() public to detect PCI hot removal.
We *know* when the device was hot removed, so I think there's no need
to guess that based on reading "all ones" from mmio (which may happen
for entirely legitimate reasons unrelated to hot removal).

Thanks,

Lukas