On 07/28/2017 07:44 AM, Corentin Labbe wrote:

On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote:

quoted

quoted

quoted

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

yes

reg2: 0x0044
reg3: 0X1500

Copy/paste error, its 1400

quoted

So this is not about loading the correct PHY driver. You can already
do this based on the PHY IDs...

This is about selecting which PHY to use. Internal or External?	

     Andrew

It is too late when we know the PHY ID.

We need to set a syscon for choosing external/internal PHY.
So we can rely only on DT.

Since the Device Tree needs to be correct to identify which PHY to use
(internal or external), if you use the standard compatible string for
the PHY that contains its OUI, e.g:

compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22"

then you can have your Ethernet MAC identify whether this is an internal
PHY by having a list of compatible strings to match against.

Corentin, can you make sure you copy netdev, Andrew and myself on the
next submissions so we don't have to keep track of seemingly identical
threads (this one + the rockchip dwmac changes) and we can work towards
one solution?

Thanks
-- 
Florian