Thread (4 messages) 4 messages, 2 authors, 2017-07-13

[PATCH] arm64: dts: ls1012a: add USB host controller nodes

From: shawnguo@kernel.org (Shawn Guo)
Date: 2017-07-13 08:57:38
Also in: linux-devicetree, lkml

On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote:
quoted
quoted
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index b497ac1..8aa2dcf 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -411,6 +411,23 @@
 				 <&clockgen 4 3>;
 		};

+		usb0: usb3 at 2f00000 {
+			compatible = "snps,dwc3";
+			reg = <0x0 0x2f00000 0x0 0x10000>;
+			interrupts = <0 60 0x4>;
+			dr_mode = "host";
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,dis_rxdet_inp3_quirk;
+		};
+
+		usb1: usb2 at 8600000 {
+			compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
+			reg = <0x0 0x8600000 0x0 0x1000>;
+			interrupts = <0 139 0x4>;
+			dr_mode = "host";
+			phy_type = "ulpi";
+		};
Please keep the nodes sorted in unit-address.

Shawn
Do you mean to move the node 'usb1: usb2 at 8600000' forward to where it's address is just before  '@8600000 '?
I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.
The nodes under simple-bus are maintained in order of unit-address.
Please respect that.

usb2 at 8600000 should go after sata at 3200000 with the current nodes.

Shawn
quoted
quoted
+
 		sata: sata at 3200000 {
 			compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
 			reg = <0x0 0x3200000 0x0 0x10000>,
--
2.1.0.27.g96db324
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help