[PATCH] arm64: dts: ls1012a: add USB host controller nodes

-----Original Message-----
From: Shawn Guo [mailto:shawnguo at kernel.org]
Sent: Thursday, July 13, 2017 4:07 PM
To: Ran Wang <redacted>
Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
[off-list ref]; Catalin Marinas [off-list ref]; Will
Deacon [off-list ref]; Andy Tang [off-list ref]; Harninder
Rai [off-list ref]; Horia Geant? [off-list ref]; open
list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[off-list ref]; moderated list:ARM64 PORT (AARCH64
ARCHITECTURE) [off-list ref]; open list <linux-
kernel at vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes

On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:

quoted

LS1012A has one USB 3.0(DWC3) controller and one USB 2.0 controller.

Signed-off-by: Ran Wang <redacted>
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi

b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index b497ac1..8aa2dcf 100644

--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi

@@ -411,6 +411,23 @@
 				 <&clockgen 4 3>;
 		};

+		usb0: usb3 at 2f00000 {
+			compatible = "snps,dwc3";
+			reg = <0x0 0x2f00000 0x0 0x10000>;
+			interrupts = <0 60 0x4>;
+			dr_mode = "host";
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,dis_rxdet_inp3_quirk;
+		};
+
+		usb1: usb2 at 8600000 {
+			compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
+			reg = <0x0 0x8600000 0x0 0x1000>;
+			interrupts = <0 139 0x4>;
+			dr_mode = "host";
+			phy_type = "ulpi";
+		};

Please keep the nodes sorted in unit-address.

Shawn

Do you mean to move the node 'usb1: usb2 at 8600000' forward to where it's address is just before  '@8600000 '?
I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.

Ran

quoted

+
 		sata: sata at 3200000 {
 			compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
 			reg = <0x0 0x3200000 0x0 0x10000>,
--
2.1.0.27.g96db324