[PATCH v2] gpio: mvebu: fix regmap_update_bits usage
From: Chris.Packham@alliedtelesis.co.nz (Chris Packham)
Date: 2017-06-11 21:54:21
Also in:
linux-gpio, lkml
From: Chris.Packham@alliedtelesis.co.nz (Chris Packham)
Date: 2017-06-11 21:54:21
Also in:
linux-gpio, lkml
On 10/06/17 00:22, Ralph Sennhauser wrote:
On Fri, 9 Jun 2017 12:09:17 +0200 Gregory CLEMENT [off-list ref] wrote:quoted
In some place in the driver regmap_update_bits was misused. Indeed the last argument is not the value of the bit (or group of bits) itself but the mask value inside the register. So when setting the bit N, then the value must be BIT(N) and not 1. CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz> CC: Ralph Sennhauser <redacted> Signed-off-by: Gregory CLEMENT <redacted> ---Hi Gregory, Tested-by: Ralph Sennhauser <redacted> Thanks for the prompt fix Ralph
Also works for me Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>