Thread (5 messages) 5 messages, 5 authors, 2017-06-16

[PATCH v2] gpio: mvebu: fix regmap_update_bits usage

From: Thomas Petazzoni <hidden>
Date: 2017-06-09 11:01:29
Also in: linux-gpio, lkml

Hello,

On Fri,  9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote:
In some place in the driver regmap_update_bits was misused. Indeed the
last argument is not the value of the bit (or group of bits) itself but
the mask value inside the register.

So when setting the bit N, then the value must be BIT(N) and not 1.

CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
CC: Ralph Sennhauser <redacted>
Signed-off-by: Gregory CLEMENT <redacted>
Reviewed-by: Thomas Petazzoni <redacted>

Thanks for fixing this so quickly!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help