[PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver
From: Pavel Machek <hidden>
Date: 2017-06-03 22:17:46
Also in:
linux-devicetree, linux-media, lkml
Hi!
quoted
quoted
According to the docs V4L2_CID_EXPOSURE_ABSOLUTE is in 100 usec units. OTOH V4L2_CID_EXPOSURE has no defined unit, so it's a better fit IMO.quoted
Way more drivers appear to be using EXPOSURE than EXPOSURE_ABSOLUTE, too.Done, switched to V4L2_CID_EXPOSURE. It's true, this control is not taking 100 usec units, so unit-less is better.Thanks. If you know the units, it would be of course better to use right units...Steve: what's the unit in this case? Is it lines or something else? Pavel: we do need to make sure the user space will be able to know the unit, too. It's rather a case with a number of controls: the unit is known but there's no API to convey it to the user. The exposure is a bit special, too: granularity matters a lot on small values. On most other controls it does not.
Yeah. Basically problem with exposure is that the control is logarithmic; by using linear scale we got too much resolution at long times and too little resolution at short times. (Plus, 100 usec ... n900 can do times _way_ shorter than that.) Anyway, even u32 gives us enough range, but I so the linear/log confusion does not matter. But it would be nicer if values were in 10 usec or usec, not 100 usec... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170604/6f0aa838/attachment-0001.sig>