Thread (67 messages) 67 messages, 7 authors, 2017-06-07
STALE3305d

[PATCH] platform: video-mux: fix ptr_ret.cocci warnings

From: kbuild test robot <hidden>
Date: 2017-05-25 07:52:29
Also in: linux-devicetree, linux-media, lkml

drivers/media/platform/video-mux.c:246:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Fengguang Wu <redacted>
---

 video-mux.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/media/platform/video-mux.c
+++ b/drivers/media/platform/video-mux.c
@@ -243,10 +243,7 @@ static int video_mux_probe_mmio_mux(stru
 	field.lsb = ffs(mask) - 1;
 
 	vmux->field = devm_regmap_field_alloc(dev, regmap, field);
-	if (IS_ERR(vmux->field))
-		return PTR_ERR(vmux->field);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(vmux->field);
 }
 #endif
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help