Thread (11 messages) 11 messages, 6 authors, 2017-03-15

[PATCH -next v2] pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data()

From: Linus Walleij <hidden>
Date: 2017-03-14 10:29:28
Also in: linux-gpio, linux-samsung-soc

On Tue, Feb 21, 2017 at 2:49 PM, Marek Szyprowski
[off-list ref] wrote:
Sadly this patch breaks support for IMEM pinctrl block on Exynos5433/TM2
and it took us some time to find the source of the problem.

devm_ioremap_resource() is not functionally a full equivalent of
devm_ioremap(). The problem here is that registers for IMEM and ALIVE
pin controllers are shared and both devices have <0x11090000 0x1000>
range in their reg property. devm_ioremap_resource() maps given
resource exclusively for the device, while devm_ioremap() allows
non-exclusive mappings.

This patch has to be reverted asap.
Patch reverted for fixes, copying the above text as commit message.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help