On Sun, Mar 26, 2017 at 07:05:48PM +0200, Stephan M?ller wrote:

Am Sonntag, 26. M?rz 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:

Hi 	Krzysztof,

quoted

quoted

quoted

quoted

+       if (slen < EXYNOS_RNG_SEED_SIZE) {
+               dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
slen); +               return -EINVAL;
+       }

Will it be helpful to print the required seed size?

It is in /proc/crypto... It is not a problem to print it but isn't that
redundant?

Not necessary if it is already available.

Maybe the dev_warn should be removed. Note, unprivileged user space can 
trigger this warning by simply invoking the seeding operation over and over 
again with an insufficient seed size. This would clutter the log.

Makes sense. The generic dev_dbg() before would bring enough
information.

Best regards,
Krzysztof