[PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
From: Stephan Müller <hidden>
Date: 2017-03-26 17:06:00
Also in:
linux-crypto, linux-samsung-soc, lkml
From: Stephan Müller <hidden>
Date: 2017-03-26 17:06:00
Also in:
linux-crypto, linux-samsung-soc, lkml
Am Sonntag, 26. M?rz 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan: Hi Krzysztof,
quoted
quoted
quoted
+ if (slen < EXYNOS_RNG_SEED_SIZE) { + dev_warn(rng->dev, "Seed too short (only %u bytes)\n", slen); + return -EINVAL; + }Will it be helpful to print the required seed size?It is in /proc/crypto... It is not a problem to print it but isn't that redundant?Not necessary if it is already available.
Maybe the dev_warn should be removed. Note, unprivileged user space can trigger this warning by simply invoking the seeding operation over and over again with an insufficient seed size. This would clutter the log. Ciao Stephan