[PATCH] phy: meson8b-usb2: fix offsets for some of the registers
From: jbrunet@baylibre.com (Jerome Brunet)
Date: 2017-02-10 09:27:54
Also in:
linux-amlogic
On Fri, 2017-01-13 at 19:53 +0100, Martin Blumenstingl wrote:
The register offsets for REG_DBG_UART (and all following) were off by 0x4. This was not a problem yet because these registers are currently not used by the driver. Signed-off-by: Martin Blumenstingl [off-list ref]
Good catch ! Thx. Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
quoted hunk ↗ jump to hunk
--- ?drivers/phy/phy-meson8b-usb2.c | 6 +++--- ?1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c index 33c9f4ba157d..30f56a6a411f 100644--- a/drivers/phy/phy-meson8b-usb2.c +++ b/drivers/phy/phy-meson8b-usb2.c@@ -81,9 +81,9 @@? #define REG_ADP_BC_ACA_PIN_GND BIT(25 ) ? #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26) ? -#define REG_DBG_UART 0x14 +#define REG_DBG_UART 0x10 ? -#define REG_TEST 0x18 +#define REG_TEST 0x14 ? #define REG_TEST_DATA_IN_MASK GENMASK (3, 0) ? #define REG_TEST_EN_MASK GENMASK(7, 4) ? #define REG_TEST_ADDR_MASK GENMASK(11 , 8)@@ -93,7 +93,7 @@? #define REG_TEST_DATA_OUT_MASK GENMAS K(19, 16) ? #define REG_TEST_DISABLE_ID_PULLUP BIT(20) ? -#define REG_TUNE 0x1c +#define REG_TUNE 0x18 ? #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0) ? #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2) ? #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)