Thread (228 messages) 228 messages, 14 authors, 2017-03-26

[PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

From: linux@armlinux.org.uk (Russell King - ARM Linux)
Date: 2017-02-18 09:25:02
Also in: linux-devicetree, linux-media, lkml

On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote:
Hi Russell,

I signed-off on this but after more review I'm not sure this is right.

The CSI-2 receiver really has no control over frame rate. It's output
frame rate is the same as the rate that is delivered to it.

So this subdev should either not implement these ops, or it should
refer them to the attached source subdev.
Where in the V4L2 documentation does it say that is permissible?

If you don't implement these, media-ctl fails to propagate _anything_
to the next sink pad if you specify a frame rate, because media-ctl
throws an error and exits immediately.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help